Don't log error when evaluating aliases array #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louisheath
changed the title
pipt
reviewed
Mar 19, 2024
expr/js_eval.go
Outdated
| return resultValue, nil | ||
|
|
||
| case isArray(result): | ||
| fmt.Fprintf(os.Stdout, "\n Source %s evaluates to an array. Handling separately\n", source) |
There was a problem hiding this comment.
Do we need to log anything here? I'm not sure we should. I think we'll only hit this when we try to evaluate an alias JS expression as a string but it returns an array, and the user doesn't need to know about that.
There was a problem hiding this comment.
we're catering for our known path but a user could write all sorts of bad configuration , e.g.
name: $.aliases
in this case we don't error but it's worth making some level of noise imo
pipt
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when parsing aliases we
this flow results in an error being logged.
this PR prevents that error log